Skip to content

Add guidance on method binding for class components#7113

Merged
Gonals merged 3 commits into
mainfrom
marcaaron-noUnnecessaryBind
Jan 12, 2022
Merged

Add guidance on method binding for class components#7113
Gonals merged 3 commits into
mainfrom
marcaaron-noUnnecessaryBind

Conversation

@marcaaron

Copy link
Copy Markdown
Contributor

Details

This is something I see done wrong often and wanted to add it to the style guide so we stop doing it.

Fixed Issues

Tests

Tested On

@marcaaron marcaaron self-assigned this Jan 10, 2022
@marcaaron marcaaron marked this pull request as ready for review January 10, 2022 23:48
@marcaaron marcaaron requested a review from a team as a code owner January 10, 2022 23:48
@MelvinBot MelvinBot requested review from Gonals and removed request for a team January 10, 2022 23:49
@Gonals Gonals merged commit 249fe5f into main Jan 12, 2022
@Gonals Gonals deleted the marcaaron-noUnnecessaryBind branch January 12, 2022 11:03
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Gonals in version: 1.1.27-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Gonals in version: 1.1.27-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Gonals in version: 1.1.27-3 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants